Skip to content

fix: fix rust warning for unused import#331

Open
stringhandler wants to merge 1 commit intoBlockstreamResearch:masterfrom
stringhandler:fix/fix_clippy_unused_import
Open

fix: fix rust warning for unused import#331
stringhandler wants to merge 1 commit intoBlockstreamResearch:masterfrom
stringhandler:fix/fix_clippy_unused_import

Conversation

@stringhandler
Copy link

Adds in this allow for this warning in rust-simplicity.

warning: unused import: `crate::decode_bits`
 --> src\jet\init\elements.rs:6:5
  |
6 | use crate::decode_bits;
  |     ^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default

The import is used in the bitcoin jet, so it can't be excluded from the generation. My Haskell is not up to scratch enough for me to put in more complicated logic. That said, if I work out how to do it in future, I will put in another PR.

@apoelstra
Copy link
Collaborator

Sorry for the delay on this -- my local CI system had some sort of hiccup (which often happens on this repo because it uses an uncommen Nix setup and tends to go months between PRs, in which time I change stuff..).

I should maybe configure it to just post errors on Github when it fails, which would improve transparency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants